Add variadic generics version of Defaults.updates()
#191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
commented
Sep 30, 2024
| } | ||
|
|
||
| for key in repeat (each keys) { | ||
| let observation = DefaultsObservation(object: key.suite, key: key.name) { _, _ in |
There was a problem hiding this comment.
Note: I'm intentionally not using CompositeDefaultsObservation for simplicity, as it's not really needed here.
sindresorhus
force-pushed
the
updates-variadic
branch
from
d294cfb to
de47a2a
Compare
sindresorhus
force-pushed
the
updates-variadic
branch
from
de47a2a to
1637cf4
Compare
sindresorhus
force-pushed
the
updates-variadic
branch
from
1637cf4 to
39c3496
Compare
hank121314
reviewed
Oct 1, 2024
| let immutableObservations = observations | ||
|
|
||
| continuation.onTermination = { _ in | ||
| // `invalidate()` should be thread-safe, but it is not in practice. |
There was a problem hiding this comment.
Curious about this. I thought that invalidate() would be thread-safe with Lock,
Should we use DispatchQueue.sync instead inside the DefaultsObservation?
There was a problem hiding this comment.
I'm not 100% sure. I have seen KVO crashes in some of my apps that may have been caused by some threading problems in macOS. I prefer to keep it limited to this code until I can 100% confirm it. This is just a precaution.
There was a problem hiding this comment.
Got it! Thanks for the explanation!
hank121314
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.